feature: add fury serializer support #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/org/apache/seata/core/serializer/SerializerType.java
# Conflicts: # dependencies/pom.xml
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7038 +/- ##
============================================
+ Coverage 52.66% 52.67% +0.01%
- Complexity 6688 6697 +9
============================================
Files 1132 1134 +2
Lines 40286 40310 +24
Branches 4724 4724
============================================
+ Hits 21215 21234 +19
- Misses 17039 17042 +3
- Partials 2032 2034 +2
|
funky-eyes
reviewed
Dec 30, 2024
| try { | ||
| return (T) threadSafeFury.deserialize(bytes); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
应该将其输出为error日志，或者抛出异常
It should be output as an error log, or an exception should be thrown
There was a problem hiding this comment.
The code for the test exception was not completely cleaned up. Done
slievrly
reviewed
Jan 3, 2025
dependencies/pom.xml
Outdated
| @@ -879,6 +882,12 @@ | |||
| <version>${rocketmq-version}</version> | |||
| </dependency> | |||
|
|
|||
| <!-- Fury Serialize --> | |||
There was a problem hiding this comment.
Does it need to be declared in the seata-all pom?
There was a problem hiding this comment.
This is not the pom.xml of the seata-all module, but the seata-dependencies module.
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
…ture-fury-serialize # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
funky-eyes
added
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add support for serializing rpc messages using Fury
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
set transport.serialization=fury
Ⅴ. Special notes for reviews